Interpret value of kill_delay as milliseconds #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related link #397 But I think this solution is better, with nice backward compatibility considerations. |
|
I think the code is great but could u add more test cases for it, once the code is covered i will merge it |
|
@xiantang Tests cases added. Let me know if you want something different. |
xiantang
approved these changes
Dec 27, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #462 +/- ##
==========================================
- Coverage 70.24% 69.31% -0.93%
==========================================
Files 9 8 -1
Lines 1035 1046 +11
==========================================
- Hits 727 725 -2
- Misses 235 245 +10
- Partials 73 76 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kill_delayis parsed as a Duration (ref). When given as an integer (as in the example config), it is interpreted as nanoseconds, not milliseconds. The sleep will be too short to allow a program to respond to the interrupt and stop cleanly. This change allows the number to be interpreted as milliseconds.This change is made to preserve backwards compatibility. If the value is specified as an value under 1 millisecond/1 000 000 nanoseconds, like
500in the example config, the value will be interpreted as the number of milliseconds. For users who figured out that you may specify the time as a duration string like”2s”or use large nanosecond integers like2000000000for 2 seconds, the behavior will remain the same.An alternative is changing
kill_delayto be parsed as an integer, likedelayandrerun_delay. This will break users who used duration strings or large numbers.This may be the root cause of the problem reported in #216, as a sufficient value for
kill_delayto allow a program to stop gracefully solved this problem for me.